Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show warning when clicking outside editing block #891

Merged
merged 1 commit into from
Jun 29, 2023

Conversation

owi92
Copy link
Member

@owi92 owi92 commented Jun 27, 2023

This opens the same modal that is used for the cancel button, and follows the same logic, i.e. when the form is untouched, it just closes. Otherwise the user needs to confirm whether they want to continue or cancel editing.
Closes #881

This opens the same modal that is used for the cancel button,
and follows the same logic, i.e. when the form is untouched,
it just closes. Otherwise the user needs to confirm whether they
want to continue or cancel editing.
@owi92 owi92 added the changelog:user User facing changes label Jun 27, 2023
@github-actions github-actions bot temporarily deployed to test-deployment-pr891 June 27, 2023 06:22 Destroyed
Copy link
Member

@LukasKalbertodt LukasKalbertodt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Neat!

@LukasKalbertodt LukasKalbertodt merged commit 4d1ab0a into elan-ev:master Jun 29, 2023
2 checks passed
@owi92 owi92 deleted the editing-block-outside-click branch March 4, 2024 16:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog:user User facing changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Editing a block and prevents navigation but doesn't show a warning
2 participants