-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add email user property #899
Conversation
This allows Tobira to handle a user's email address. It is crucial when Tobira creates a user reference in Opencast via JWT login.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the thorough PR! You had to touch a lot of files and I don't think you missed anything :D
I still don't understand the motivation behind the PR, though. You said "user reference in Opencast via JWT" but... what does that mean? Why is an email address useful in that case? Can you elaborate?
In our setup, if the user gets in touch with our system for the first time via Tobira, the user reference is created with the data from Tobiras JWT Token, and because it does not contain the email address, a dummy one is built like in the docs example. With a valid email address, sending emails via workflows is possible, and I like consistent data ;). Seems related to #672 |
Yeah that makes sense! With my inline comments fixed, this PR can be merged! |
I removed the email from the user |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just one tiny thing!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot!
This PR adds an optional user email property; this is useful if Tobira creates the user reference in Opencast via JWT.
There is a bug if the email column contains a null value; I wonder if I made a mistake or if the macro/FieldIndex does not support null values from the database.