Check upload permission for upload route and "upload" nav item #903
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hide the upload menu entry and show an error on the upload page if the user misses the upload permission.
|
Thank you for this. @LukasKalbertodt asked me (internally) to fix this in #896 and I have done so, but since that is more focused on design and therefore waiting for approval from ETH and Bern, I think we can get your PR in before that. I'd still wait for Lukas' approval before merging, but that is more of a formality in this case. |
|
So now poor Jose doesn't see the upload option? Nice. Thanks, Gregor. |
LukasKalbertodt
approved these changes
Jul 12, 2023
LukasKalbertodt
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the problem that Jose sees the upload menu entry and can access the upload form without having the appropriate role.
Expected:
