Close burger menu when clicking specific items #916
Conversation
There was a problem hiding this comment.
That's indeed borderline hacky :/
I know that we plan on refactoring all of this anyway (#840), but could you check whether you can instead use useMenu().close() in the code where the respective nav items are defined? That might be better?
|
Oh also: The issue also mentions closing this when a realm without children is reached. What are your thoughts on that? |
These links neither have children nor a parent realm to link back to, so closing them on click should be intuitive.
owi92
force-pushed
the
close-burger-menu-in-specific-cases
branch
from
a5aa75f
to
0f978f6
Compare
|
Oh yes thanks for pointing that out, I didn't have the Regarding realms without children, I think you made some valid points in #906 (back button, consistency with other realms) that convinced me to keep the burger menu open for these. |
|
Fair! |
Closes #906
The items on which the menu closes are:
The solution presented here is a little hacky since the burger menu as written currently gets passed the navigation lists as nested JSX elements, which makes passing the
closehandler directly to the specific items quite complicated (if possible at all).This should be taken into consideration when/if the sidebox/burger navigation get refactored or rewritten eventually.