Make user role prefixes configurable #974
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some users, usually provided by external systems, have user roles starting with `ROLE_AAI_USER_` for example. To make the ACL UI work properly in those cases, we need to make it configurable. We also considered getting this information from Opencast instead of having to configure it twice. However, there were some problems: - Currently it is configured in two places in Opencast. - Those cannot be lists, but only a single role. At least right now. - Unclear how to best retrieve that value from Opencast. Building a custom API and all that jazz takes time. - Maybe Admin UI and Tobira should be configured independently, maybe we don't actually want to entangle them too much.
Two separate things were fixed: - Super long unbreakable labels (long unknown roles) would just not break on wide screens and overflow terribly. - Special user entries (either yourself, or the unknown user) were broken into multiple lines weirdly as the parent container is flex. Both can be checked on the video "On the Shore of the Cosmic Ocean" (L3TEYHLXRxf).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See commits.