Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace manual DOM ids with "useId()" hook #980

Merged
merged 1 commit into from
Nov 7, 2023
Merged

Replace manual DOM ids with "useId()" hook #980

merged 1 commit into from
Nov 7, 2023

Conversation

owi92
Copy link
Member

@owi92 owi92 commented Oct 25, 2023

Closes #670

I also did a bit of good ol wave-plugin "testing". There are still some places with the missing form label error. But that's something for another PR I'd say.

@owi92 owi92 changed the title Replace manual DOM ids with useId() Replace manual DOM ids with "useId()" hook Oct 25, 2023
@github-actions github-actions bot temporarily deployed to test-deployment-pr980 October 25, 2023 16:30 Destroyed
@owi92 owi92 added the changelog:nope Not worth mentioning in the changelog label Oct 26, 2023
LukasKalbertodt
LukasKalbertodt requested changes Nov 7, 2023
View reviewed changes
Copy link
Member

@LukasKalbertodt LukasKalbertodt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small stuff

frontend/src/routes/manage/Realm/General.tsx Outdated Show resolved Hide resolved
frontend/src/ui/SearchableSelect.tsx Outdated Show resolved Hide resolved
frontend/src/ui/SearchableSelect.tsx Outdated Show resolved Hide resolved
@github-actions github-actions bot temporarily deployed to test-deployment-pr980 November 7, 2023 13:40 Destroyed
@LukasKalbertodt
Copy link
Member

Thanks for getting rid of this!

@LukasKalbertodt LukasKalbertodt merged commit caab215 into elan-ev:master Nov 7, 2023
2 checks passed
@owi92 owi92 deleted the replace-manual-dom-ids branch March 4, 2024 16:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LukasKalbertodt LukasKalbertodt LukasKalbertodt approved these changes

Assignees
No one assigned
Labels
changelog:nope Not worth mentioning in the changelog
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Get rid of all manual DOM IDs (often used with htmlFor on labels)
2 participants
@owi92 @LukasKalbertodt