Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adjust some translations #987

Merged
merged 1 commit into from
Nov 13, 2023
Merged

Adjust some translations #987

merged 1 commit into from
Nov 13, 2023

Conversation

owi92
Copy link
Member

@owi92 owi92 commented Nov 8, 2023

Closes #857

@github-actions github-actions bot temporarily deployed to test-deployment-pr987 November 8, 2023 12:22 Destroyed
@owi92 owi92 mentioned this pull request Nov 8, 2023
Closed
@owi92 owi92 added the changelog:user User facing changes label Nov 8, 2023
LukasKalbertodt
LukasKalbertodt approved these changes Nov 8, 2023
View reviewed changes
Copy link
Member

@LukasKalbertodt LukasKalbertodt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good to me! I will wait with merging until we have a response from Olaf.

@owi92 owi92 mentioned this pull request Nov 9, 2023
Closed
@github-actions github-actions bot temporarily deployed to test-deployment-pr987 November 9, 2023 15:38 Destroyed
@github-actions github-actions bot temporarily deployed to test-deployment-pr987 November 13, 2023 10:19 Destroyed
LukasKalbertodt
LukasKalbertodt approved these changes Nov 13, 2023
View reviewed changes
Copy link
Member

@LukasKalbertodt LukasKalbertodt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Olaf also seems to be happy with these changes. So let's merge. We can of course always add more adjustments in the future.

@LukasKalbertodt LukasKalbertodt merged commit 45fada3 into elan-ev:master Nov 13, 2023
2 checks passed
@owi92 owi92 deleted the wording-coherence branch March 4, 2024 16:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LukasKalbertodt LukasKalbertodt LukasKalbertodt approved these changes

Assignees
No one assigned
Labels
changelog:user User facing changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Wording: DE/EN coherence
2 participants
@owi92 @LukasKalbertodt