Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace feather icons with lucide icons #994

Merged
merged 1 commit into from
Nov 14, 2023

Conversation

owi92
Copy link
Member

@owi92 owi92 commented Nov 13, 2023

There are two feather icons the we use that are missing from lucide icons: edit and edit3. I left these as feather icons, but we could consider using similar ones from lucide (though I do like the feather ones more).

Closes #988

@owi92 owi92 added the changelog:nope Not worth mentioning in the changelog label Nov 13, 2023
@github-actions github-actions bot temporarily deployed to test-deployment-pr994 November 13, 2023 13:45 Destroyed
@LukasKalbertodt
Copy link
Member

Thanks for tackling this task!

edit and edit3 seem to have been renamed to pen-square and pen-line respectively. Or were you talking about those? I don't see a difference to the feather ones.

@github-actions github-actions bot temporarily deployed to test-deployment-pr994 November 13, 2023 19:38 Destroyed
Copy link
Member

@LukasKalbertodt LukasKalbertodt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Again, thanks for doing this probably-not-the-most-fun-of-all task!

@LukasKalbertodt LukasKalbertodt merged commit 5d7db9c into elan-ev:master Nov 14, 2023
2 checks passed
@owi92 owi92 deleted the replace-icons branch March 4, 2024 16:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog:nope Not worth mentioning in the changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Replace all imports of Feather icons with Lucide imports
2 participants