Option for handling user defined null value strings #34
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more. Additional details and impacted files@@ Coverage Diff @@
## 0_1_12-release #34 +/- ##
=================================================
Coverage ? 92.72%
=================================================
Files ? 21
Lines ? 316
Branches ? 0
=================================================
Hits ? 293
Misses ? 23
Partials ? 0 ☔ View full report in Codecov by Sentry. |
dazfuller
added a commit
that referenced
this pull request
Oct 25, 2023
* Update build.sbt Set new snapshot version * add ability to handle user define null value strings (#34) * Update poi version to 5.2.3 (#32) * Update poi version to 5.2.3 * Update build to account for log4j conflicts across spark versions * Spark 3.4.1 Support (#36) * add spark 3.4.1 to build process * add missing copyright header * add 3.4.1 to powershell build script * update version for merge * update for spark 3.5 support (#39) --------- Co-authored-by: Jose Soto <josecsmorales@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR resolves #31 by adding an option for a user to specify a null value string. The usage of this option is as follows
It performs a case-insensitive comparison so that "na" matches with "NA"