Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the serve command #152

Closed
HyperBrain opened this issue Jul 12, 2017 · 9 comments
Closed

Remove the serve command #152

HyperBrain opened this issue Jul 12, 2017 · 9 comments
Assignees
Labels
Milestone

Comments

@HyperBrain
Copy link
Member

HyperBrain commented Jul 12, 2017

This is a Feature Task

Description

In #135 we decided that the serve command will be removed because it does
not add additional value to the Serverless framework as the serverless-offline
integrates with the plugin and does the job even better.

This task should contain all (technical) discussions about the actual removal, so
that it can be removed without affecting the other commands/features that will stay
in the plugin.

The target milestone for the removal is version 3.0.0 as it is (by definition) a breaking change
that needs actions to be taken by users that currently use it.

All PRs for the feature have to be targeted to the (new) v3.0.0-remove-serve branch to keep master clean
for any 2.x.x bugfix or feature versions. We will use this branch to stabilize the feature. The branch will be
rebased to master each time something is added there.

Similar or dependent issue(s):

@HyperBrain HyperBrain added this to the 3.0.0 milestone Jul 12, 2017
@HyperBrain
Copy link
Member Author

@hassankhan Are you interested (and have time) to take care of this?

Additionally to removing the command, we also have to check for then obsolete dependencies that can be removed from the project.

@HyperBrain
Copy link
Member Author

I can take care of the "local invoke" (#151) which would also be a good addition to 3.0.0.

@hassankhan
Copy link
Contributor

I'll try and commit some time to it, as you said it needs to be carefully done and not break anything else. I'd add that it should probably be tested with serverless-offline thrown into the mix just in-case there's anything weird going on there.

@HyperBrain
Copy link
Member Author

I'll add the new issue/serve label to all issues regarding the serve command. These issues should not be worked on and they should be closed as soon as serve has been removed.

@bebbi
Copy link

bebbi commented Aug 8, 2017

I've tried to run

serverless offline start

instead of

serverless webpack serve

In the offline way, the lambdas get called, execute correctly - but they don't return a json body as they do with the serve way. I don't see any related issue in serverless-offline, maybe something related to serverless-webpack?

I'm happy to troubleshooting but don't know where to start.

@HyperBrain
Copy link
Member Author

@bebbi Maybe someone who commented in #135 can help out here. Can you post this question there (and address the ones who answered directly)?

@franciscocpg
Copy link
Member

@bebbi
Is your response in this format?

@bebbi
Copy link

bebbi commented Aug 8, 2017

@franciscocpg , answered in #135 per @HyperBrain request.

@bebbi
Copy link

bebbi commented Aug 10, 2017

This might be a good place for tracking two pending sls-offline PRs on blocking issues for some use-cases for discarding the serve command -

dherault/serverless-offline#283
dherault/serverless-offline#285

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants