fix: stop writing to blocks v1 table #72
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vasco-santos
force-pushed
the
fix/stop-writing-to-blocks-v1-table
branch
from
6364078
to
997c288
Compare
|
All good! we should also set BLOCKS_BATCH_SIZE to 25, since it's the limit for the aws batch write |
simone-sanfratello
approved these changes
Feb 10, 2023
vasco-santos
force-pushed
the
fix/stop-writing-to-blocks-v1-table
branch
from
997c288
to
b8ddbdd
Compare
This was referenced Feb 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes
indexer-lambato not write toblocks-v1table. It also removes all the environment variables associated with it.Main motivation can be seen at https://hackmd.io/@vasco-santos/ryjEfsGas . In this proposal, we were aiming to keep same state. However, team then decided that we can simply not write this for now and we can go back and get the type of each entry if we want to merge both tables tracking blocks in the future.