Consistent Builders #280
Merged
Consistent Builders #280
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This PR also refactors our address fetching a bit so that it doesn't kick in if you specify an exact set of |
KodrAus
added a commit
that referenced
this pull request
Apr 29, 2018
* rename .params to .params_fluent * only fetch next address if builder has no value * refactor client builders to use fluent methods
KodrAus
added a commit
that referenced
this pull request
May 7, 2018
* rename .params to .params_fluent * only fetch next address if builder has no value * refactor client builders to use fluent methods
KodrAus
added a commit
that referenced
this pull request
Jan 25, 2019
* rename .params to .params_fluent * only fetch next address if builder has no value * refactor client builders to use fluent methods
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a start for making the various builders on requests and the client consistent. In any case where we have an inner builder we should:
_fluentmethod that allows configuring the builder without explicitly creating it (this method does not stack)T: Into<TBuilder>so when there's an obvious default that can be passed in insteadThere are some cases where we can't use
FluentBuilderitself, likedocument_updatewith a script, since it changes the builder type, but can in other places.