-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] Replace tokio-core with tokio #317
Conversation
Thanks for taking this on @GyrosOfWar! There's a substantial set of breaking changes in the It looks like our integration tests (they live here) are failing to run. If you've got docker available you should be able to run these integration tests yourself locally: cd tests/run
cargo run Please reach out if you've any questions at all! |
I'll probably look into this over the weekend. Do you have any idea about why the |
Ah the benches are in a barely useful state right now and have suffered from bitrot, so I think we should get rid of them at this stage. Any new round of performance improvements can work with new benchmarks. If you remove the bench environment that should be enough to unblock us. |
Hi @GyrosOfWar. I've just gone and merged in about 2 years of work in progress from the Thanks again for working on this! |
Alrighty, I've rolled this up into #320 so we now use Thanks again for taking the time to do this! |
Hi!
This is a pretty big change, but I feel like it improves usability a lot (not having to pass handles around etc.). One thing that's still missing is the ability to pass in your own
reqwest::async::Client
when building an asyncelastic
client, which now might make more sense to have as a builder method.