Skip to content
This repository has been archived by the owner on Apr 12, 2022. It is now read-only.

Update syntax to make it compliant to modern ansible-lint rules #55

Merged
merged 8 commits into from Nov 18, 2019
Merged

Update syntax to make it compliant to modern ansible-lint rules #55

merged 8 commits into from Nov 18, 2019

Conversation

tgadiev
Copy link
Contributor

@tgadiev tgadiev commented Nov 16, 2019

Current elastic.beats role has many warnings in ansible-galaxy because of failing many yamllint and ansible-lint rules. This PR should fix that and make code more readable and compliant to ansible-lint rules.

Signed-off-by: Timur Gadiev <Timur_Gadiev@epam.com>
Signed-off-by: Timur Gadiev <Timur_Gadiev@epam.com>
Signed-off-by: Timur Gadiev <Timur_Gadiev@epam.com>
Signed-off-by: Timur Gadiev <Timur_Gadiev@epam.com>
Signed-off-by: Timur Gadiev <Timur_Gadiev@epam.com>
Signed-off-by: Timur Gadiev <Timur_Gadiev@epam.com>
Signed-off-by: Timur Gadiev <Timur_Gadiev@epam.com>
Signed-off-by: Timur Gadiev <Timur_Gadiev@epam.com>
@elasticmachine
Copy link
Collaborator

Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually?

@cla-checker-service
Copy link

Author of the following commits did not sign a Contributor Agreement:
22a5738, f3bdd67, 17fc38e, 57d5b1b, f9f6b26, efab627, 65b778a, 97f0f65

Please, read and sign the above mentioned agreement if you want to contribute to this project

Copy link
Member

@jmlrt jmlrt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @tgadiev, thanks for this PR!

@jmlrt
Copy link
Member

jmlrt commented Nov 18, 2019

Jenkins test this please

1 similar comment
@jmlrt
Copy link
Member

jmlrt commented Nov 18, 2019

Jenkins test this please

@jmlrt jmlrt merged commit 2c595a3 into elastic:master Nov 18, 2019
@jmlrt
Copy link
Member

jmlrt commented Dec 2, 2019

Hi @tgadiev,
Mostly thanks to your contribution Ansible Galaxy quality score for this role went from 2.3 to 4.9 https://galaxy.ansible.com/elastic/beats 👍

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants