For #36 - Add support for creating optional elasticsearch user and group

[jerrac]

Here's the pull request. :) Per #36 (comment)

[elasticsearch-release]

Jenkins standing by to test this. If you aren't a maintainer, you can ignore this comment. Someone with commit access, please review this and clear it for Jenkins to run; then say 'jenkins, test it'.

[gingerwizard]

@jerrac apologies some other build issues associated with neillturner/kitchen-ansible#7 resolving. Will test this once we resolve.

[gingerwizard]

@jerrac Can we simplify this to just be es_user_uid & es_group_id? If either are specified we apply them to the elasticsearch user?

Also i think its worth raising an issue to be able to specify the user name i.e. change it from elasticsearch. I suggest we assume this user exists - relying on other roles/playbook to create it.

[jerrac]

@gingerwizard I'll switch to es_user_id and es_group_id.

If either are specified we apply them to the elasticsearch user?

So, get ride of es_optional_user: True|False, and just use es_user_id is defined or es_group_id is defined on the appropriate tasks?

Also i think its worth raising an issue to be able to specify the user name i.e. change it from elasticsearch. I suggest we assume this user exists - relying on other roles/playbook to create it.

Don't we already have that? es_user, and es_group in defaults/main.yml.

[gingerwizard]

@jerrac yes we do! thanks :) I was confused because your pull uses literal "elasticsearch" rather than es_user and es_group.

Agreed re the other changes

[gingerwizard]

@jerrac LGTM. I'll test it shortly.

I think its worth adding a quick server spec test. Maybe to the config-2x and config-1x suites. Are you happy to do this or shall i add?

[gingerwizard]

jenkins, test it

[jerrac]

I haven't used kitchen yet. I remember hearing about it once and thinking I should learn it. Heh.

So, would adding tests for this just involve adding the vars to one of the playbooks in the test/integration directory?

[gingerwizard]

@jerrac The tests seemed to have failed. It appears you need explicit is defined checks. It also worth checking the parameters are defined and not empty.

Yes ideally a test would use the parameters in one of the test playbooks - probably config is best. Server spec can then be used confirm the user id and group id were set correctly after the role had been applied here.

[jerrac]

I don't need to edit the config_spec.rb files, right?

[gingerwizard]

Yes you can add it there. It will then run for be tested for 1x and 2x.
http://serverspec.org/resource_types.html#user
Is probably what you want.

[jerrac]

Would this work for config-2x/serverspec/default_spec.rb? (Since those are the values I set in the config.yml file.)

require 'config_spec'
require 'user_spec'
require 'group_spec'

describe 'Config Tests v 2.x' do
  include_examples 'config::init', "2.1.0"
end

describe group('elasticuser') do
  it { should exist }
end

describe group('elasticuser') do
  it { should have_gid 333 }
end

describe user('elasticuser') do
  it { should exist }
end

describe user('elasticuser') do
  it { should belong_to_group 'elasticuser' }
end

describe user('elasticuser') do
  it { should have_uid 333 }
end

btw, thanks for coaching me through this stuff. 😄

[jerrac]

Or maybe I should stick those in config_spec.rb.

Speaking of that file, would this section cause the tests to fail if the user is not elasticsearch?

If so, should I keep the es_user, and es_group values as "elasticsearch" in the test?

[gingerwizard]

Hi
Put it in config_sepc and then it will run for 1.x and 2.x. You can drop the 2.x test then. I would keep the username as elasticsearch - we currently dont have code to create an alternative user just set the uid and guid.

[gingerwizard]

Hey @jerrac thanks for this. We will test this, we're just experiencing some issues with the build env not clearing up docker images properly. Once we've resolved this ill run it and hopefully merged. Please feel free to contribute elsewhere, its really appreciated.

[gingerwizard]

infra problems hopefully solved so without further ado...

jenkins, test it

[gingerwizard]

@jerrac in an effort to improve stability the role has changed which is now causing conflicts. Can you please resolve and repush?

[jerrac]

@gingerwizard Erm, did those changes help? Or am I missing something?

[dliappis]

jenkins, test it

[dliappis]

jenkins, test it

[jerrac]

I rebased to master. Did that help?

And after poking around Jenkins some more, I found where to view the errors that caused the failure. Which is what I was missing when I was checking things earlier. :\

[gingerwizard]

jenkins, test it

[gingerwizard]

@jerrac all tests pass! merging. Thanks for the contribution!