Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Captured error's context should not change after capture #191

Closed
SergeyKleyman opened this issue Apr 19, 2019 · 3 comments
Closed

Captured error's context should not change after capture #191

SergeyKleyman opened this issue Apr 19, 2019 · 3 comments
Assignees
@gregkalapos
Labels
bug Something isn't working good first issue Good for newcomers

Comments

@SergeyKleyman
Copy link
Contributor

Currently we copy a reference to transaction's context to captured error instance (AKA shallow copy) so error's context changes if transaction's context changes which is incorrect - error's context should not change after capture.
@SergeyKleyman SergeyKleyman added the bug Something isn't working label Apr 19, 2019
@SergeyKleyman SergeyKleyman mentioned this issue Apr 19, 2019
Merged
@SergeyKleyman
Copy link
Contributor Author

Add tests to verify that in particular error's context won't have Response property.

@SergeyKleyman SergeyKleyman added this to the 1.0 milestone Jun 22, 2019
@SergeyKleyman SergeyKleyman added the good first issue Good for newcomers label Jul 17, 2019
@gregkalapos gregkalapos modified the milestones: 1.0, 1.1 Jul 24, 2019
@gregkalapos gregkalapos removed this from the 1.1 milestone Sep 4, 2019
@gregkalapos
Copy link
Contributor

gregkalapos commented Sep 4, 2019 •
edited
Loading

Decision: this is a nice to have, not needed in the next release. by @axw

@gregkalapos gregkalapos mentioned this issue Oct 19, 2020
Merged
@gregkalapos
Copy link
Contributor

Implemented in #982.

@gregkalapos gregkalapos self-assigned this Nov 4, 2020
@zube zube bot unassigned gregkalapos Nov 4, 2020
@zube zube bot removed the [zube]: Done label Feb 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@gregkalapos gregkalapos

Labels
bug Something isn't working good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@gregkalapos @SergeyKleyman @alvarolobato