Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

filter resource file request #418

Closed
ignite-404 opened this issue Jul 30, 2019 · 8 comments
Closed

filter resource file request #418

ignite-404 opened this issue Jul 30, 2019 · 8 comments
Labels
enhancement New feature or request

Comments

@ignite-404
Copy link

drop those

@ignite-404 ignite-404 added the enhancement New feature or request label Jul 30, 2019
@gregkalapos
Copy link
Contributor

You don't want the agent to capture those, right?

Some options we can do here:

  • Add a config to disable capturing those (e.g. based on extension)
  • Not capturing those et all (probably not the way to go)
  • Do something on the UI/APM Server

I'm also asking on other channels what other agents do.

@gregkalapos
Copy link
Contributor

@SergeyKleyman
Copy link
Contributor

@hiwjcn Could you add a little bit more about your use case? I have a feeling that you might be using ElasticApmModule from Elastic.Apm.AspNetFullFramework - is it correct? If so please take a look at #346 - by adding managedHandler to modules precondition monitoring can be limited to dynamic pages (URLs handled by ASP.NET) excluding static content.

@ignite-404
Copy link
Author

@SergeyKleyman hey bro,im using asp.net core

Elastic.Apm.All, Version=1.0.0.0, Culture=neutral, PublicKeyToken=ae7400d2c189cf22

app.UseElasticApm(config);

and configuration like this:

  "ElasticApm": {
    "LogLevel": "Debug",
    "ServerUrls": "http://3h.elk.hiwj.cn:8200",
    "TransactionSampleRate": 1.0
  }

@ignite-404
Copy link
Author

@SergeyKleyman @gregkalapos is there any api like this:

app.UseElasticApm(config,option=>
{
option.filter.add(url=>!url.endwith(".css"));
option.filter.add(url=>!url.endwith(".js"));
option.filter.add(url=>regex.match(url));
});

@gregkalapos
Copy link
Contributor

@SergeyKleyman @gregkalapos is there any api like this:

app.UseElasticApm(config,option=>
{
option.filter.add(url=>!url.endwith(".css"));
option.filter.add(url=>!url.endwith(".js"));
option.filter.add(url=>regex.match(url));
});

No, we don't have it in .NET. We know other agent have similar filters. We already had some initial discussion about this, no final decision if we add it to .NET or not - probably it'd make sense to add it.

@gregkalapos
Copy link
Contributor

@gregkalapos gregkalapos mentioned this issue Mar 26, 2020
2 tasks
@gregkalapos
Copy link
Contributor

Some update on this:
In #792 we introduced a filter API - with that you'll be able to filter out specific requests. This feature will be out with the next release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants