Fix failing API tests - again #104
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It looks like the timers on the VMs in CI have a very low resolution. Therefore we wait even longer in the API tests.
Enable 10% inaccuracy (due to `await Task.Delay` inaccuracy)
|
First build was green, all test pass. Re-triggered to give it another try, if it's still green I'll merge it. |
|
Found 1 test which was not updated. Re-run again. |
gregkalapos
changed the title
|
Tests green, we build fails because of our known "threshold" issue, which is WIP. I merge this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It looks like the timers on the VMs in CI have a very low resolution.
Therefore we wait even longer in the API tests.Update: waiting longer does not help, we enable 10% error due to this inaccuracy in
await Task.Delay. I think it's fine, we don't wanna measure in these tests with a super high accuracy, the point is that if we have a 10ms wait in the code than the duration should be around 10ms.. (and not 0 or 1..., but e.g. 9,12ms due to this inaccuracy is imo fine)Solves #94