Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Suppport latest version of Microsoft.Data.SqlClient #1988

Merged
merged 7 commits into from Feb 23, 2023
Merged

Suppport latest version of Microsoft.Data.SqlClient #1988

merged 7 commits into from Feb 23, 2023

Conversation

z1c0
Copy link
Contributor

@z1c0 z1c0 commented Jan 25, 2023 •
edited

Support for the latest version 5.*..

@z1c0 z1c0 linked an issue Jan 25, 2023 that may be closed by this pull request
Support auto instrumentation of Microsoft.Data.SqlClient for versions >= 3.0 #1902
Closed
@elastic-apm-tech elastic-apm-tech added this to In Progress in APM-Agents (OLD) Jan 25, 2023
@z1c0 z1c0 changed the title Bump dependency Suppport latest version of Microsoft.Data.SqlClient Jan 25, 2023
@apmmachine
Copy link
Collaborator

apmmachine commented Jan 25, 2023 •
edited

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview previewSnapshots

Expand to view the summary

Build stats

  • Start Time: 2023-02-23T14:33:17.960+0000

  • Duration: 88 min 53 sec

Test stats 🧪

Test Results
Failed 0
Passed 22691
Skipped 175
Total 22866

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

  • run benchmark tests : Run the benchmark test.

  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

@z1c0 z1c0 force-pushed the 1902-support-auto-instrumentation-of-microsoftdatasqlclient-for-versions-=-30 branch 2 times, most recently from d117800 to 137b695 Compare January 27, 2023 11:57
@z1c0 z1c0 force-pushed the 1902-support-auto-instrumentation-of-microsoftdatasqlclient-for-versions-=-30 branch from 523a3c3 to 5ab3b6b Compare February 22, 2023 16:14
@z1c0 z1c0 marked this pull request as ready for review February 23, 2023 12:38
@z1c0 z1c0 requested a review from Mpdreamz February 23, 2023 12:39
Mpdreamz
Mpdreamz approved these changes Feb 23, 2023
View reviewed changes
Copy link
Member

@Mpdreamz Mpdreamz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@z1c0 z1c0 force-pushed the 1902-support-auto-instrumentation-of-microsoftdatasqlclient-for-versions-=-30 branch from 515cf74 to 1a22b3b Compare February 23, 2023 14:32
@z1c0 z1c0 merged commit a3f1d60 into main Feb 23, 2023
APM-Agents (OLD) automation moved this from In Progress to Done Feb 23, 2023
@z1c0 z1c0 deleted the 1902-support-auto-instrumentation-of-microsoftdatasqlclient-for-versions-=-30 branch February 23, 2023 17:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Mpdreamz Mpdreamz Mpdreamz approved these changes

Assignees
No one assigned
Labels
agent-dotnet
Projects
APM-Agents (OLD)
  
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support auto instrumentation of Microsoft.Data.SqlClient for versions >= 3.0
3 participants
@z1c0 @apmmachine @Mpdreamz