-
Notifications
You must be signed in to change notification settings - Fork 204
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move to minver for automatic versioning #2063
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
💔 Build Failed
Expand to view the summary
Build stats
Test stats 🧪
Steps errors
Expand to view the steps failures
|
v1v
added a commit
to v1v/apm-integration-testing
that referenced
this pull request
Aug 8, 2023
v1v
added a commit
to elastic/apm-integration-testing
that referenced
this pull request
Aug 8, 2023
joecwu
pushed a commit
to joecwu/apm-integration-testing
that referenced
this pull request
Aug 31, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This brings
apm-agent-dotnet
in line with other .NET repositories from elastic.Uses: https://github.com/adamralph/minver as nuget package to version .NET assemblies:
Currently our apm agent libraries are not versioned according to
https://learn.microsoft.com/en-ca/dotnet/standard/library-guidance/versioning#version-numbers
The guidance is to anchor AssemblyVersion to
M.0.0
So that strict assembly version loading on .NET full framework is more relaxed
like the new behavior on .NET core.
We can't do so on
1.x.x
because we already released1.Minor.x
versions.So instead we will anchor to
1.Minor.0
insteadThis also versions the
elastic_apm_profiler
externally throughminver-cli
albeit a tad hacky sincecargo
norcargo make
really has an option to provide this externally.