Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move to minver for automatic versioning #2063

Merged
merged 27 commits into from
May 24, 2023
Merged

Move to minver for automatic versioning #2063

merged 27 commits into from
May 24, 2023

Conversation

Mpdreamz
Copy link
Member

@Mpdreamz Mpdreamz commented Apr 28, 2023

This brings apm-agent-dotnet in line with other .NET repositories from elastic.

Uses: https://github.com/adamralph/minver as nuget package to version .NET assemblies:

Currently our apm agent libraries are not versioned according to
https://learn.microsoft.com/en-ca/dotnet/standard/library-guidance/versioning#version-numbers

The guidance is to anchor AssemblyVersion to M.0.0
So that strict assembly version loading on .NET full framework is more relaxed
like the new behavior on .NET core.

We can't do so on 1.x.x because we already released 1.Minor.x versions.

So instead we will anchor to 1.Minor.0 instead

This also versions the elastic_apm_profiler externally through minver-cli albeit a tad hacky since cargo nor cargo make really has an option to provide this externally.

@apmmachine
Copy link
Collaborator

apmmachine commented Apr 28, 2023

💔 Build Failed

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2023-05-16T15:41:08.932+0000

  • Duration: 66 min 14 sec

Test stats 🧪

Test Results
Failed 0
Passed 2538
Skipped 33
Total 2571

Steps errors 1

Expand to view the steps failures

Create Docker Image
  • Took 0 min 0 sec . View more details here
  • Description: .ci/linux/build_docker.sh

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

  • run benchmark tests : Run the benchmark test.

  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

@Mpdreamz Mpdreamz merged commit 91628fa into main May 24, 2023
10 checks passed
APM-Agents (OLD) automation moved this from In Progress to Done May 24, 2023
@Mpdreamz Mpdreamz deleted the fix/move-to-minver branch May 24, 2023 08:21
v1v added a commit to v1v/apm-integration-testing that referenced this pull request Aug 8, 2023
v1v added a commit to elastic/apm-integration-testing that referenced this pull request Aug 8, 2023
joecwu pushed a commit to joecwu/apm-integration-testing that referenced this pull request Aug 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Development

Successfully merging this pull request may close these issues.

None yet

2 participants