-
Notifications
You must be signed in to change notification settings - Fork 205
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ensure Agent.Setup on .NET FullFramework behaves the same #2069
Conversation
💔 Tests Failed
Expand to view the summary
Build stats
Test stats 🧪
Test errors
Expand to view the tests failures
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Ensures that on .NET FullFramework we always use ConfigurationManager
3a26cac
to
923d932
Compare
Ensures that on .NET FullFramework we always use ConfigurationManager.
Right now this is only the when you use our
ElasticApmModule
on IIS.By moving the basis of this configuration to
Elastic.Apm
we can switch the defaultIConfigurationReader
on .NET full framework fromEnvironmentConfiguration
toAppsettingsConfiguration