Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure Agent.Setup on .NET FullFramework behaves the same #2069

Merged
merged 7 commits into from
Jun 5, 2023

Conversation

Mpdreamz
Copy link
Member

@Mpdreamz Mpdreamz commented May 16, 2023

Ensures that on .NET FullFramework we always use ConfigurationManager.

Right now this is only the when you use our ElasticApmModule on IIS.

By moving the basis of this configuration to Elastic.Apm we can switch the default IConfigurationReader on .NET full framework from EnvironmentConfiguration to AppsettingsConfiguration

@apmmachine
Copy link
Collaborator

apmmachine commented May 16, 2023

💔 Tests Failed

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2023-05-16T15:56:04.219+0000

  • Duration: 47 min 15 sec

Test stats 🧪

Test Results
Failed 2
Passed 2188
Skipped 30
Total 2220

Test errors 2

Expand to view the tests failures

Initializing / Parallel / Windows .NET Framework / Test / AppSettingsTests.Elastic.Apm.Tests.Config.AppSettingsTests.CreateConfigurationReaderThroughEnvVar – Elastic.Apm.Tests.Config.AppSettingsTests
    Expand to view the error details

     Assert.NotNull() Failure 
    

    Expand to view the stacktrace

     Assert.NotNull() Failure
    Stack Trace:
       at Elastic.Apm.Tests.Config.AppSettingsTests.CreateConfigurationReaderThroughEnvVar() in C:\Users\jenkins\workspace\net_apm-agent-dotnet-mbp_PR-2069\apm-agent-dotnet\test\Elastic.Apm.Tests\Config\AppSettingsTests.cs:line 101 
    

Initializing / Parallel / Windows .NET Framework / Test / AppSettingsTests.Elastic.Apm.Tests.Config.AppSettingsTests.CreateConfigurationReaderThroughApSettings – Elastic.Apm.Tests.Config.AppSettingsTests
    Expand to view the error details

     Assert.NotNull() Failure 
    

    Expand to view the stacktrace

     Assert.NotNull() Failure
    Stack Trace:
       at Elastic.Apm.Tests.Config.AppSettingsTests.CreateConfigurationReaderThroughApSettings() in C:\Users\jenkins\workspace\net_apm-agent-dotnet-mbp_PR-2069\apm-agent-dotnet\test\Elastic.Apm.Tests\Config\AppSettingsTests.cs:line 86 
    

Steps errors 4

Expand to view the steps failures

Install dotnet SDK
  • Took 0 min 13 sec . View more details here
  • Description: mkdir -p ${DOTNET_ROOT} # Download .Net SDK installer script curl -s -O -L https://dot.net/v1/dotnet-install.sh chmod ugo+rx dotnet-install.sh # Install .Net SDKs ./dotnet-install.sh --install-dir "${DOTNET_ROOT}" -version '3.1.100' ./dotnet-install.sh --install-dir "${DOTNET_ROOT}" -version '5.0.100' ./dotnet-install.sh --install-dir "${DOTNET_ROOT}" -version '6.0.100' ./dotnet-install.sh --install-dir "${DOTNET_ROOT}" -version '7.0.100'
Archive the artifacts
  • Took 0 min 0 sec . View more details here
  • Description: [2023-05-16T16:26:38.457Z] Archiving artifacts script returned exit code 56
Test & coverage
  • Took 3 min 18 sec . View more details here
  • Description: .ci/windows/testnet461.bat
Archive the artifacts
  • Took 0 min 0 sec . View more details here
  • Description: [2023-05-16T16:28:22.074Z] Archiving artifacts script returned exit code 1

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

  • run benchmark tests : Run the benchmark test.

  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

@Mpdreamz Mpdreamz marked this pull request as ready for review May 23, 2023 18:55
Copy link
Contributor

@stevejgordon stevejgordon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Mpdreamz Mpdreamz force-pushed the fix/config-defaults-to-agent-setup branch from 3a26cac to 923d932 Compare June 5, 2023 11:30
@Mpdreamz Mpdreamz merged commit c688d8f into main Jun 5, 2023
11 checks passed
APM-Agents (OLD) automation moved this from In Progress to Done Jun 5, 2023
@Mpdreamz Mpdreamz deleted the fix/config-defaults-to-agent-setup branch June 5, 2023 13:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Development

Successfully merging this pull request may close these issues.

None yet

3 participants