Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Npgsql 7.x support to profiler #2103

Merged
merged 5 commits into from Jun 9, 2023
Merged

Add Npgsql 7.x support to profiler #2103

merged 5 commits into from Jun 9, 2023

Conversation

Mpdreamz
Copy link
Member

@Mpdreamz Mpdreamz commented Jun 5, 2023

  • add support for npgsql 7.x
  • Update Npgsql's ExecuteNonQuery instrumentation
  • Remove all bad npgsql bindings

This should get rid off all No rejit method found for target: warnings in the profiler logs.

The integrations were looking for non existing methods in npgsql

Fixes: #2103

@elastic-apm-tech elastic-apm-tech added this to In Progress in APM-Agents (OLD) Jun 5, 2023
@Mpdreamz Mpdreamz mentioned this pull request Jun 5, 2023
@Mpdreamz Mpdreamz linked an issue Jun 5, 2023 that may be closed by this pull request
Copy link
Contributor

@stevejgordon stevejgordon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, with one question.

@Mpdreamz Mpdreamz merged commit 235468d into main Jun 9, 2023
14 checks passed
APM-Agents (OLD) automation moved this from In Progress to Done Jun 9, 2023
@Mpdreamz Mpdreamz deleted the fix/npgsql-7-support branch June 9, 2023 09:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Development

Successfully merging this pull request may close these issues.

Npgsql 7 Support
2 participants