Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

isolate azure tests #2128

Merged
merged 10 commits into from
Jul 10, 2023
Merged

isolate azure tests #2128

merged 10 commits into from
Jul 10, 2023

Conversation

Mpdreamz
Copy link
Member

@Mpdreamz Mpdreamz commented Jul 5, 2023

No description provided.

Mpdreamz and others added 3 commits July 5, 2023 15:06
Signed-off-by: Adrien Mannocci <adrien.mannocci@elastic.co>
Signed-off-by: Adrien Mannocci <adrien.mannocci@elastic.co>
Signed-off-by: Adrien Mannocci <adrien.mannocci@elastic.co>
Signed-off-by: Adrien Mannocci <adrien.mannocci@elastic.co>
Signed-off-by: Adrien Mannocci <adrien.mannocci@elastic.co>
Signed-off-by: Adrien Mannocci <adrien.mannocci@elastic.co>
Copy link
Contributor

@stevejgordon stevejgordon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Mpdreamz
Copy link
Member Author

The test reporter needs to be tweaked slightly,

Currently any test suite that is no match will still emit a xunit log file with no tests.

https://github.com/elastic/apm-agent-dotnet/runs/14863078120

We should add a step that removes these prior to the upload so that we don't end up overwriting a previous valid run.

Will tackle this in a separate PR though.

@Mpdreamz Mpdreamz merged commit e646ef8 into main Jul 10, 2023
14 checks passed
APM-Agents (OLD) automation moved this from In Progress to Done Jul 10, 2023
@Mpdreamz Mpdreamz deleted the feature/azure-tests branch July 10, 2023 17:22
v1v added a commit to v1v/apm-agent-java that referenced this pull request Dec 18, 2023
v1v added a commit to v1v/apm-agent-java that referenced this pull request Dec 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Development

Successfully merging this pull request may close these issues.

None yet

4 participants