-
Notifications
You must be signed in to change notification settings - Fork 205
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
isolate azure tests #2128
isolate azure tests #2128
Conversation
Signed-off-by: Adrien Mannocci <adrien.mannocci@elastic.co>
Signed-off-by: Adrien Mannocci <adrien.mannocci@elastic.co>
4fba535
to
568db57
Compare
Signed-off-by: Adrien Mannocci <adrien.mannocci@elastic.co>
Signed-off-by: Adrien Mannocci <adrien.mannocci@elastic.co>
aa5c8e8
to
1a1019b
Compare
Signed-off-by: Adrien Mannocci <adrien.mannocci@elastic.co>
Signed-off-by: Adrien Mannocci <adrien.mannocci@elastic.co>
ab98783
to
dbc3e8c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
The test reporter needs to be tweaked slightly, Currently any test suite that is no match will still emit a xunit log file with no tests. https://github.com/elastic/apm-agent-dotnet/runs/14863078120 We should add a step that removes these prior to the upload so that we don't end up overwriting a previous valid run. Will tackle this in a separate PR though. |
No description provided.