Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

json-specs: cgroup_parsing has been removed #2193

Merged
merged 1 commit into from
Oct 10, 2023

Conversation

v1v
Copy link
Member

@v1v v1v commented Oct 5, 2023

What

I created an empty json file so the updatecli will be the one updating it in the next run.

Why

Fix the failures when updating the json-specs using updatecli

Further details

Likely test/Elastic.Apm.Tests/SystemInfoHelperTests.cs will need to be adjusted since cgroup_parsing.json does not exist anymore in the elastic/apm.git

Issues

Caused by elastic/apm#807

add empty container_metadata_discovery.json
@v1v v1v requested review from a team October 5, 2023 06:59
@v1v v1v self-assigned this Oct 5, 2023
@elastic-apm-tech elastic-apm-tech added this to In Progress in APM-Agents (OLD) Oct 5, 2023
Copy link
Member

@Mpdreamz Mpdreamz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Mpdreamz Mpdreamz merged commit 583f085 into elastic:main Oct 10, 2023
15 checks passed
APM-Agents (OLD) automation moved this from In Progress to Done Oct 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Development

Successfully merging this pull request may close these issues.

None yet

3 participants