Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

action(post-release): use fetch-depth, quoting and fix git commands #2205

Merged
merged 6 commits into from
Oct 19, 2023
Merged

action(post-release): use fetch-depth, quoting and fix git commands #2205

merged 6 commits into from
Oct 19, 2023

Conversation

v1v
Copy link
Member

@v1v v1v commented Oct 19, 2023 •
edited

depth is not a valid argument... :/

Set fetch-depth: 0 to fetch all history for all branches and tag

In addition I fixed some quoting and git commands

Test

This build is the one testing the post-release steps. 馃懠 for not testing this earlier :/

v1v#40 was created automatically (i used some cosmetic changes to validate this)

@v1v
action: use fetch-depth for cloning
a0bd2d1 
`depth` is not a valid argument... :/
@v1v v1v requested a review from a team October 19, 2023 11:47
@elastic-apm-tech elastic-apm-tech added this to In Progress in APM-Agents (OLD) Oct 19, 2023
Mpdreamz
Mpdreamz previously approved these changes Oct 19, 2023
View reviewed changes
Copy link
Member

@Mpdreamz Mpdreamz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Eek! Good catch!

@v1v v1v changed the title action: use fetch-depth for cloning action: use fetch-depth for cloning and fix quoting Oct 19, 2023
@v1v v1v marked this pull request as draft October 19, 2023 12:12
@v1v v1v changed the title action: use fetch-depth for cloning and fix quoting action(post-release): use fetch-depth, quoting and fix git commands Oct 19, 2023
@v1v v1v marked this pull request as ready for review October 19, 2023 12:31
@v1v v1v merged commit 5314fe4 into main Oct 19, 2023
13 checks passed
APM-Agents (OLD) automation moved this from In Progress to Done Oct 19, 2023
@v1v v1v self-assigned this Oct 19, 2023
@v1v v1v deleted the v1v-patch-1 branch January 18, 2024 14:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Mpdreamz Mpdreamz Mpdreamz approved these changes

Assignees

@v1v v1v

Labels
agent-dotnet
Projects
APM-Agents (OLD)
  
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@v1v @Mpdreamz