Switch to Licence expression rather than file #2264
Conversation
|
💚 CLA has been signed |
|
👋 @thompson-tomo Thanks a lot for your contribution! It may take some time before we review a PR, so even if you don’t see activity for some time, it does not mean that we have forgotten about it. Every once in a while we go through a process of prioritization, after which we are focussing on the tasks that were planned for the upcoming milestone. The prioritization status is typically reflected through the PR labels. It could be pending triage, a candidate for a future milestone, or have a target milestone set to it. |
thompson-tomo
force-pushed
the
chore/#2258_SwitchToLicenceExpression
branch
from
e1b96f8
to
8e1e3da
Compare
thompson-tomo
force-pushed
the
chore/#2258_SwitchToLicenceExpression
branch
from
8e1e3da
to
ddded22
Compare
There was a problem hiding this comment.
LGTM! Sorry this took a tad longer than expected. Since https://github.com/elastic/apm-agent-dotnet/tree/main/src/instrumentations/Elastic.Apm.MongoDb is donated code I had to be sure we still attributed enough.
Since we still include both the license and notice files in the nuget package itself and attribute in the source code we can move to SPDX identifier instead. Like we do for our other .NET packages.
Thank you for opening this up @thompson-tomo 👍
|
run elasticsearch-ci/docs |
|
No problem at all @Mpdreamz thanks for merging it. |
This moves the packages to use a licence expression rather than the file and is consistent with the other Elastic packages ie Elastic.CommonSchema.
Closes #2258