Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Address a few synchronization issues in the codebase #2276

Merged
merged 5 commits into from Feb 5, 2024
Merged

Address a few synchronization issues in the codebase #2276

merged 5 commits into from Feb 5, 2024

Conversation

Mpdreamz
Copy link
Member

@Mpdreamz Mpdreamz commented Feb 2, 2024

  • ensure Add() is locked on composite disposable
  • Ensure _dynamicMethods is readonly in ILHelpersExtensions
  • fix synchronization issue in ModuleLookup
  • _reflectionObject should not be static in BinaryConverter

@elastic-apm-tech elastic-apm-tech added this to In Progress in APM-Agents (OLD) Feb 2, 2024
stevejgordon
stevejgordon approved these changes Feb 5, 2024
View reviewed changes
Copy link
Contributor

@stevejgordon stevejgordon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Mpdreamz Mpdreamz merged commit aacb5cc into main Feb 5, 2024
14 checks passed
APM-Agents (OLD) automation moved this from In Progress to Done Feb 5, 2024
@Mpdreamz Mpdreamz deleted the fix/composite-dispose-check branch February 5, 2024 11:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stevejgordon stevejgordon stevejgordon approved these changes

Assignees
No one assigned
Labels
agent-dotnet
Projects
APM-Agents (OLD)
  
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Mpdreamz @stevejgordon