Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Further logging refinements in ElasticApmModule #2299

Merged
merged 2 commits into from
Feb 26, 2024

Conversation

stevejgordon
Copy link
Contributor

This continues to work to improve the diagnostics in ElasticApmModule by attempting to create the logger earlier in the Init method. This allows any exceptions to be logged to the IApmLogger, which may be helpful if something critical occurs during the rest of the Init method.

It adds some additional log messages to trace the progress of the Init method.

Mpdreamz
Mpdreamz previously approved these changes Feb 23, 2024
Copy link
Member

@Mpdreamz Mpdreamz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@stevejgordon stevejgordon merged commit 6fe527d into main Feb 26, 2024
11 checks passed
APM-Agents (OLD) automation moved this from In Progress to Done Feb 26, 2024
@stevejgordon stevejgordon deleted the enhancement/elasticapmmodule-logging branch February 26, 2024 11:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Development

Successfully merging this pull request may close these issues.

None yet

2 participants