Further logging refinements in ElasticApmModule #2299
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mpdreamz
reviewed
Feb 23, 2024
src/integrations/Elastic.Apm.AspNetFullFramework/ElasticApmModule.cs
Outdated
Show resolved
Hide resolved
Mpdreamz
approved these changes
Feb 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This continues to work to improve the diagnostics in
ElasticApmModuleby attempting to create the logger earlier in theInitmethod. This allows any exceptions to be logged to theIApmLogger, which may be helpful if something critical occurs during the rest of theInitmethod.It adds some additional log messages to trace the progress of the
Initmethod.