Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for transaction_name_groups and use_path_as_transaction_name #2331

Merged
merged 11 commits into from
Apr 16, 2024

Conversation

stevejgordon
Copy link
Contributor

Adds support for these new config options and updates the ElasticApmModule implementation to apply them accordingly.

Closes #2318

@stevejgordon stevejgordon added the enhancement New feature or request label Apr 12, 2024
@stevejgordon
Copy link
Contributor Author

It looks like having the WCF sample included is a bit of a problem for the CI builds, as the target might not be there by default. I'll strip it for now, as it's nice but not worth much effort.

@stevejgordon stevejgordon marked this pull request as draft April 15, 2024 13:20
@stevejgordon stevejgordon marked this pull request as ready for review April 16, 2024 12:27
Mpdreamz
Mpdreamz previously approved these changes Apr 16, 2024
Copy link
Member

@Mpdreamz Mpdreamz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! LGTM 🚢 🇮🇹

@stevejgordon stevejgordon merged commit aa8fd7e into main Apr 16, 2024
13 checks passed
@stevejgordon stevejgordon deleted the enhancement/2262 branch April 16, 2024 15:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support transaction_name_groups and use_path_as_transaction_name
2 participants