New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: real stack #239 #240
feat: real stack #239 #240
Conversation
Codecov Report
@@ Coverage Diff @@
## master #240 +/- ##
==========================================
+ Coverage 76.61% 81.82% +5.21%
==========================================
Files 66 59 -7
Lines 2245 1882 -363
Branches 443 322 -121
==========================================
- Hits 1720 1540 -180
+ Misses 399 209 -190
- Partials 126 133 +7
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @skynet2!
I already played with this in #6, originally I also wanted to somehow transform the whole state-machine to the original call stack not only getting the real method names.
This library is very promising, but did not work on my machine (more about it in #6): https://github.com/benaadams/Ben.Demystifier
Nevertheless this is definitely a step forward, so I'd be happy to merge this. Hope you don't mind, but I also pushed 2 tests covering this to your PR.
I added 1 comment regarding fileName
- once that's addressed I think we are good to go.
Thanks for your contribution!
In line 35: Conditional access qualifier expression is known to be not null - removed `?`
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you Stas!
No description provided.