Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: real stack #239 #240

Merged
merged 6 commits into from Jun 2, 2019

Conversation

skynet2
Copy link
Contributor

@skynet2 skynet2 commented May 27, 2019

No description provided.

@codecov-io
Copy link

codecov-io commented May 28, 2019

Codecov Report

Merging #240 into master will increase coverage by 5.21%.
The diff coverage is 68%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #240      +/-   ##
==========================================
+ Coverage   76.61%   81.82%   +5.21%     
==========================================
  Files          66       59       -7     
  Lines        2245     1882     -363     
  Branches      443      322     -121     
==========================================
- Hits         1720     1540     -180     
+ Misses        399      209     -190     
- Partials      126      133       +7
Impacted Files Coverage Δ
src/Elastic.Apm/Helpers/StacktraceHelper.cs 73.46% <68%> (-9.29%) ⬇️
src/Elastic.Apm/Sampler.cs 56.75% <0%> (-27.03%) ⬇️
.../Elastic.Apm/Config/AbstractConfigurationReader.cs 71.85% <0%> (-11.69%) ⬇️
...Apm.AspNetCore/Config/MicrosoftExtensionsConfig.cs 72.72% <0%> (-10.61%) ⬇️
...gnosticListeners/HttpDiagnosticListenerImplBase.cs 62.16% <0%> (-4.51%) ⬇️
src/Elastic.Apm/Logging/ConsoleLogger.cs 85.71% <0%> (-0.96%) ⬇️
...astic.Apm/Config/EnvironmentConfigurationReader.cs 100% <0%> (ø) ⬆️
src/Elastic.Apm/Config/ConfigConsts.cs 100% <0%> (ø) ⬆️
...tic.Apm/Report/Serialization/MetricSetConverter.cs
src/Elastic.Apm/Metrics/MetricsCollector.cs
... and 8 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5628f4e...0c65d40. Read the comment docs.

Copy link
Contributor

@gregkalapos gregkalapos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @skynet2!

I already played with this in #6, originally I also wanted to somehow transform the whole state-machine to the original call stack not only getting the real method names.

This library is very promising, but did not work on my machine (more about it in #6): https://github.com/benaadams/Ben.Demystifier

Nevertheless this is definitely a step forward, so I'd be happy to merge this. Hope you don't mind, but I also pushed 2 tests covering this to your PR.

I added 1 comment regarding fileName - once that's addressed I think we are good to go.

Thanks for your contribution!

src/Elastic.Apm/Helpers/StacktraceHelper.cs Outdated Show resolved Hide resolved
@gregkalapos gregkalapos self-assigned this May 31, 2019
In line 35: Conditional access qualifier expression is known to be not null - removed `?`
@gregkalapos gregkalapos self-requested a review June 2, 2019 09:51
Copy link
Contributor

@gregkalapos gregkalapos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you Stas!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants