Feature/gh 34 dependency version #35
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
December 24, 2018 23:19
Added null check to verify that we have a reference to an active transaction before we attempt to create a new span from it.
Changed Elastic.Apm.AspNetCore project to target 2.0.0 dependencies.
gregkalapos
approved these changes
Dec 25, 2018
There was a problem hiding this comment.
Awesome! Please ping me once you signed our CLA. Once it's done, I'll merge this.
Thank you!
|
Hi @josiahpeters, we have found your signature in our records, but it seems like you have signed with a different e-mail than the one used in yout Git commit. Can you please add both of these e-mails into your Github profile (they can be hidden), so we can match your e-mails to your Github profile? |
|
Thanks @josiahpeters, the "first community contributor in the elastic .NET APM Agent" title goes to you! 🎉🎉 |
|
Woohoo! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I changed the aspnet core dependency versions to 2.0.0 to allow projects that were freshly created when 2.0.0 aspnetcore was shipped the ability to work with Elastic.Apm.AspNetCore