Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

module/apmgrpc: traces are broken by sampling #601

Closed
axw opened this issue Jul 29, 2019 · 0 comments · Fixed by #602
Closed

module/apmgrpc: traces are broken by sampling #601

axw opened this issue Jul 29, 2019 · 0 comments · Fixed by #602

Comments

@axw
Copy link
Member

axw commented Jul 29, 2019

Describe the bug

As seen in https://discuss.elastic.co/t/only-common-trace-id-for-sampled-spans/192459, sampling is breaking distributed tracing in apmgrpc.

Expected behavior

The apmgrpc client interceptor should include the transaction's trace context when spans are dropped (e.g. due to sampling or the max spans limit has been reached), like in the apmhttp client instrumentation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant