module/apmgrpc: fix trace propagation vs. sampling #602
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
axw
force-pushed
the
apmgrpc-dropped-span-tracecontext
branch
from
0a6a5ea
to
8166ff9
Compare
Add WithTransaction and WithTransactionOptions methods to RecordingTracer, and update the top-level functions to be implemented in terms of them. This enables calling those functions with a customised tracer.
Fix a bug in the client interceptor which would break trace propagation when facing dropped spans or non-sampled transactions. In these cases we should propagate the transaction's trace context, rather than sending nothing in the outgoing metadata which would restart tracing.
axw
force-pushed
the
apmgrpc-dropped-span-tracecontext
branch
from
8166ff9
to
faf2be7
Compare
|
jenkins run the tests please |
1 similar comment
|
jenkins run the tests please |
Codecov Report
@@ Coverage Diff @@
## master #602 +/- ##
==========================================
+ Coverage 87.76% 87.81% +0.04%
==========================================
Files 122 122
Lines 7456 7470 +14
==========================================
+ Hits 6544 6560 +16
+ Misses 811 810 -1
+ Partials 101 100 -1
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix a bug in the client interceptor which would break
trace propagation when facing dropped spans or non-sampled
transactions. In these cases we should propagate the
transaction's trace context, rather than sending nothing
in the outgoing metadata which would restart tracing.
Fixes #601