Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Stop recording http.request.socket.encrypted #1129

Merged
merged 3 commits into from
Sep 28, 2021
Merged

Stop recording http.request.socket.encrypted #1129

merged 3 commits into from
Sep 28, 2021

Conversation

marclop
Copy link
Contributor

@marclop marclop commented Sep 23, 2021 •
edited
Loading

Description

Deprecates the http.request.socket.encrypted field in the apm agent,
and stops recording it in the modules that populated that field:

  • module/apmhttp
  • module/apmgrpc
  • module/apmfiber

Related issues

Closes #1122

@marclop
Stop recording http.request.socket.encrypted
c9558de 
Deprecates the `http.request.socket.encrypted` field in the apm agent,
and stops recording it in the modules that populated that field:
    - `module/apmhttp`
    - `module/apmgrpc`
    - `module/apmfiber`

Signed-off-by: Marc Lopez Rubio <marc5.12@outlook.com>
@marclop marclop self-assigned this Sep 23, 2021
@marclop marclop added v7.16.0 and removed agent-go labels Sep 23, 2021
@elastic-apm-tech elastic-apm-tech added this to In Progress in APM-Agents (OLD) Sep 23, 2021
@AlexanderWert AlexanderWert added this to the 7.16 milestone Sep 23, 2021
@apmmachine
Copy link
Collaborator

apmmachine commented Sep 23, 2021 •
edited
Loading

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2021-09-28T10:15:05.008+0000

  • Duration: 32 min 30 sec

  • Commit: 916e6f1

Test stats 🧪

Test Results
Failed 0
Passed 11082
Skipped 268
Total 11350

🤖 GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

  • run benchmark tests : Run the benchmark test.

@marclop
Add changelog, fix imports
94712af 
Signed-off-by: Marc Lopez Rubio <marc5.12@outlook.com>
@marclop marclop requested a review from a team September 23, 2021 11:21
@marclop marclop enabled auto-merge (squash) September 28, 2021 10:14
@marclop marclop merged commit e815cd0 into elastic:master Sep 28, 2021
APM-Agents (OLD) automation moved this from In Progress to Done Sep 28, 2021
@marclop marclop deleted the f/stop-recording-http.request.socket.encrypted-and-reprecate-field branch September 28, 2021 10:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stuartnelson3 stuartnelson3 stuartnelson3 approved these changes

Assignees

@marclop marclop

Labels
v7.16.0
Projects
APM-Agents (OLD)
  
Done
Milestone
7.16
Development

Successfully merging this pull request may close these issues.

[META 507] Stop collecting the field http.request.socket.encrypted
4 participants
@marclop @apmmachine @stuartnelson3 @AlexanderWert