Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix apmcloudutil logger assignment #1158

Merged
merged 2 commits into from
Nov 25, 2021
Merged

Conversation

axw
Copy link
Member

@axw axw commented Nov 25, 2021

If logging isn't configured, apmlog.DefaultLogger will be nil. apmlog.DefaultLogger has a pointer-to-struct type, so converting it to apmcloudutil.Logger results in a non-nil interface value with a nil pointer value.

Assigning nil pointer to an interface.
@axw axw added the bug Something isn't working label Nov 25, 2021
@elastic-apm-tech elastic-apm-tech added this to In Progress in APM-Agents (OLD) Nov 25, 2021
@axw axw requested a review from a team November 25, 2021 01:07
@apmmachine
Copy link
Collaborator

apmmachine commented Nov 25, 2021

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2021-11-25T01:07:53.405+0000

  • Duration: 31 min 54 sec

  • Commit: abc09a4

Test stats 🧪

Test Results
Failed 0
Passed 11648
Skipped 268
Total 11916

🤖 GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

  • run benchmark tests : Run the benchmark test.

  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

@axw axw enabled auto-merge (squash) November 25, 2021 01:22
@axw axw merged commit 1ae5839 into elastic:master Nov 25, 2021
APM-Agents (OLD) automation moved this from In Progress to Done Nov 25, 2021
@axw axw deleted the apmcloudutil-logger branch November 25, 2021 02:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
agent-go bug Something isn't working
Projects
Development

Successfully merging this pull request may close these issues.

None yet

3 participants