Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

transport: default ELASTIC_APM_SERVER_URL #122

Merged
merged 1 commit into from
Jun 22, 2018

Conversation

axw
Copy link
Member

@axw axw commented Jun 22, 2018

If ELASTIC_APM_SERVER_URL is not specified,
default to http://localhost:8200 like the
other agents.

Fixes #121

If ELASTIC_APM_SERVER_URL is not specified,
default to http://localhost:8200 like the
other agents.
@codecov-io
Copy link

Codecov Report

Merging #122 into master will decrease coverage by 0.1%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #122      +/-   ##
==========================================
- Coverage   75.57%   75.47%   -0.11%     
==========================================
  Files          61       61              
  Lines        3112     3107       -5     
==========================================
- Hits         2352     2345       -7     
- Misses        577      578       +1     
- Partials      183      184       +1
Impacted Files Coverage Δ
transport/default.go 84.61% <100%> (-2.89%) ⬇️
transport/http.go 88.18% <100%> (-0.22%) ⬇️
tracer.go 85.66% <0%> (-0.74%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bcce90e...0ef6b7f. Read the comment docs.

@axw axw merged commit 9c746d6 into elastic:master Jun 22, 2018
@axw axw deleted the default-server-url branch June 22, 2018 02:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants