Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: update sns span.name to reflect the current spec #1286

Merged
merged 3 commits into from
Aug 10, 2022
Merged

feat: update sns span.name to reflect the current spec #1286

merged 3 commits into from
Aug 10, 2022

Commits on Aug 6, 2022

  1. feat: update sns span.name to reflect the current spec 

    'span.name' is correctly updated to 'SNS PUBLISH to <specific-name>'.

'TargetArn' is parsed and the endpoint UUID is excluded from the
'span.name'.

Add support for 'PhoneNumber' (note that the actual phone number is
not stored.)

See https://github.com/elastic/apm/blob/main/specs/agents/tracing-instrumentation-aws.md#sns-aws-simple-notification-service

Add more test cases to increase coverage.
    @kruskall
    kruskall committed Aug 6, 2022
    Configuration menu
    Copy the full SHA
    62031eb View commit details
    Browse the repository at this point in the history

Commits on Aug 9, 2022

  1. Merge branch 'main' into feat/fix-sns-name

    @kruskall
    kruskall committed Aug 9, 2022
    Configuration menu
    Copy the full SHA
    15ada35 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'main' into feat/fix-sns-name

    @kruskall
    kruskall committed Aug 9, 2022
    Configuration menu
    Copy the full SHA
    e9c5aae View commit details
    Browse the repository at this point in the history