Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

module/apmsql: parse SQL #129

Merged
merged 2 commits into from Jul 4, 2018
Merged

module/apmsql: parse SQL #129

merged 2 commits into from Jul 4, 2018

Conversation

axw
Copy link
Member

@axw axw commented Jul 3, 2018

Closes #103

@axw axw self-assigned this Jul 3, 2018
@axw axw force-pushed the sqlparser branch 2 times, most recently from 7a39ce5 to fa6e4ae Compare July 3, 2018 09:45
@codecov-io
Copy link

codecov-io commented Jul 3, 2018

Codecov Report

Merging #129 into master will increase coverage by 0.78%.
The diff coverage is 87.14%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #129      +/-   ##
==========================================
+ Coverage   75.99%   76.78%   +0.78%     
==========================================
  Files          61       64       +3     
  Lines        3558     3834     +276     
==========================================
+ Hits         2704     2944     +240     
- Misses        659      681      +22     
- Partials      195      209      +14
Impacted Files Coverage Δ
module/apmsql/driver.go 66.66% <100%> (+1.96%) ⬆️
module/apmsql/internal/sqlscanner/token.go 60% <60%> (ø)
module/apmsql/signature.go 84.7% <84.7%> (ø)
module/apmsql/internal/sqlscanner/scanner.go 88.88% <88.88%> (ø)
tracer.go 84.34% <0%> (-0.58%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7c25a1a...8c8e283. Read the comment docs.

@axw axw force-pushed the sqlparser branch 3 times, most recently from 9aa5ad3 to 8be9ffe Compare July 4, 2018 05:51
@axw axw changed the title module/apmsql: parse SQL (WIP) module/apmsql: parse SQL Jul 4, 2018
@axw
Copy link
Member Author

axw commented Jul 4, 2018

Added some more tests based on those in apm-agent-python. Also added a simple fuzz test, and benchmark.

axw added 2 commits July 4, 2018 14:08
Parse SQL to produce more useful span names.
And fix existing fuzz tests.
@axw axw merged commit 1ddb4af into elastic:master Jul 4, 2018
@axw axw deleted the sqlparser branch July 4, 2018 06:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants