Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix doc around span compression #1379

Merged
merged 1 commit into from
Mar 30, 2023
Merged

Fix doc around span compression #1379

merged 1 commit into from
Mar 30, 2023

Conversation

gregkalapos
Copy link
Contributor

Update doc to changes in #1256 - seems those changes weren't updated in the doc.

@gregkalapos gregkalapos requested review from bmorelli25 and a team January 30, 2023 18:54
@apmmachine
Copy link
Collaborator

apmmachine commented Jan 30, 2023 •
edited

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview previewSnapshots

Expand to view the summary

Build stats

  • Start Time: 2023-03-30T11:08:27.032+0000

  • Duration: 3 min 59 sec

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

  • run benchmark tests : Run the benchmark test.

  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

kruskall
kruskall approved these changes Mar 29, 2023
View reviewed changes
Copy link
Member

@kruskall kruskall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for this!

@gregkalapos gregkalapos enabled auto-merge (squash) March 29, 2023 19:41
@gregkalapos gregkalapos force-pushed the DocFix_SpanCompression branch 4 times, most recently from 49fad21 to 57790bf Compare March 30, 2023 11:06
@gregkalapos
Update configuration.asciidoc
4ba1d45 
Update doc to changes in elastic#1256

Signed-off-by: Greg Kalapos <gergo@kalapos.net>
@gregkalapos gregkalapos merged commit d2d35d3 into elastic:main Mar 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bmorelli25 bmorelli25 bmorelli25 approved these changes

@kruskall kruskall kruskall approved these changes

Assignees
No one assigned
Labels
agent-go
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@gregkalapos @apmmachine @bmorelli25 @kruskall