Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate specs update to updatecli #1402

Merged

Conversation

reakaleek
Copy link
Member

@reakaleek reakaleek commented Mar 9, 2023

What

Migrate https://github.com/elastic/apm/blob/main/.ci/Jenkinsfile to the consumer using updatecli and GH Actions workflows.

Why

Jenkins 2 GH Actions Migration

How to test

export GITHUB_TOKEN="<your-personal-access-token>"
export GIT_USER="FooBar"
export GIT_EMAIL="foo@bar.com"
updatecli --config .ci/updatecli.d/update-json-specs.yml diff
updatecli --config .ci/updatecli.d/update-gherkin-specs.yml diff

@reakaleek reakaleek self-assigned this Mar 9, 2023
@reakaleek reakaleek requested a review from a team March 9, 2023 14:04
@reakaleek reakaleek requested a review from a team March 9, 2023 14:04
@apmmachine
Copy link
Collaborator

apmmachine commented Mar 9, 2023

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview previewSnapshots

Expand to view the summary

Build stats

  • Start Time: 2023-03-30T06:10:03.792+0000

  • Duration: 3 min 19 sec

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

  • run benchmark tests : Run the benchmark test.

  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

Copy link
Member

@axw axw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is probably fine, but is it possible to specify a directory and keep them synchronised, like an rsync?

@reakaleek
Copy link
Member Author

This is probably fine, but is it possible to specify a directory and keep them synchronised, like an rsync?

Unfortunately, not. There was a similar request/question here: elastic/apm-agent-nodejs#3197 (comment)

@axw
Copy link
Member

axw commented Mar 22, 2023

@reakaleek no worries.

We're requiring commits to be signed now, so please squash, sign, and force-push.

Copy link
Member

@v1v v1v left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Otherwise

WARNING: **Fallback** Please add a title to you configuration using the field 'title: <your pipeline>'
Pipeline "update-jsons-specs" failed
Skipping due to:
	action stage:	"Title is too long (maximum is 256 characters)"

.ci/updatecli.d/update-gherkin-specs.yml Show resolved Hide resolved
.ci/updatecli.d/update-gherkin-specs.yml Outdated Show resolved Hide resolved
.ci/updatecli.d/update-gherkin-specs.yml Outdated Show resolved Hide resolved
.ci/updatecli.d/update-json-specs.yml Outdated Show resolved Hide resolved
.ci/updatecli.d/update-json-specs.yml Outdated Show resolved Hide resolved
@reakaleek reakaleek force-pushed the feature/migrate-specs-update-to-updatecli branch from ee350c3 to ef5b851 Compare March 29, 2023 07:13
@reakaleek reakaleek force-pushed the feature/migrate-specs-update-to-updatecli branch from ef5b851 to f08a073 Compare March 29, 2023 07:21
Co-authored-by: Victor Martinez <victormartinezrubio@gmail.com>
@reakaleek reakaleek requested a review from v1v March 30, 2023 06:12
@reakaleek reakaleek merged commit 6fe379a into elastic:main Mar 30, 2023
@reakaleek reakaleek deleted the feature/migrate-specs-update-to-updatecli branch March 30, 2023 09:29
gregkalapos pushed a commit to gregkalapos/apm-agent-go that referenced this pull request Mar 30, 2023
* Migrate specs update to updatecli

* Fix title too long error

Co-authored-by: Victor Martinez <victormartinezrubio@gmail.com>

---------

Co-authored-by: Victor Martinez <victormartinezrubio@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants