Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for span tags #213

Merged
merged 1 commit into from
Sep 9, 2018
Merged

Add support for span tags #213

merged 1 commit into from
Sep 9, 2018

Conversation

axw
Copy link
Member

@axw axw commented Sep 9, 2018

Add elasticapm.SpanContext.SetTags method.

Closes #147

Add elasticapm.SpanContext.SetTags method.
@codecov-io
Copy link

Codecov Report

Merging #213 into v2 will decrease coverage by <.01%.
The diff coverage is 79.31%.

Impacted file tree graph

@@            Coverage Diff             @@
##               v2     #213      +/-   ##
==========================================
- Coverage   80.42%   80.41%   -0.01%     
==========================================
  Files          87       87              
  Lines        5190     5219      +29     
==========================================
+ Hits         4174     4197      +23     
- Misses        818      821       +3     
- Partials      198      201       +3
Impacted Files Coverage Δ
module/apmot/span.go 86.87% <100%> (+0.16%) ⬆️
model/marshal_fastjson.go 86.69% <77.77%> (-0.27%) ⬇️
spancontext.go 91.66% <77.77%> (-8.34%) ⬇️
tracer.go 83.92% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a640e65...f969887. Read the comment docs.

@axw axw merged commit 014064d into elastic:v2 Sep 9, 2018
@axw axw deleted the v2-span-tags branch September 9, 2018 07:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants