Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

transport: server failover #233

Merged
merged 1 commit into from
Sep 25, 2018
Merged

Conversation

axw
Copy link
Member

@axw axw commented Sep 25, 2018

Add support for specifying multiple server URLs.
The transport will switch to the next server URL
in the list when a request fails. The list is
shuffled when configuring the transport to avoid
multiple agents synchronising failover.

NewHTTPTransport no longer accepts any parameters.
The constructor creates a transport based on the
environment variables and default values. Methods
have been added to (re-)configure the transport
after construction.

Closes #200

Add support for specifying multiple server URLs.
The transport will switch to the next server URL
in the list when a request fails. The list is
shuffled when configuring the transport to avoid
multiple agents synchronising failover.

NewHTTPTransport no longer accepts any parameters.
The constructor creates a transport based on the
environment variables and default values. Methods
have been added to (re-)configure the transport
after construction.
@codecov-io
Copy link

Codecov Report

Merging #233 into v2 will increase coverage by 0.01%.
The diff coverage is 91.66%.

Impacted file tree graph

@@            Coverage Diff             @@
##               v2     #233      +/-   ##
==========================================
+ Coverage   80.51%   80.52%   +0.01%     
==========================================
  Files          88       88              
  Lines        5254     5295      +41     
==========================================
+ Hits         4230     4264      +34     
- Misses        820      823       +3     
- Partials      204      208       +4
Impacted Files Coverage Δ
transport/default.go 100% <100%> (ø) ⬆️
transport/http.go 92.06% <91.54%> (+5%) ⬆️
internal/fastjson/writer.go 68.83% <0%> (-2.6%) ⬇️
tracer.go 83.03% <0%> (-0.9%) ⬇️
model/marshal_fastjson.go 86.54% <0%> (-0.33%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 09fa11b...a61be46. Read the comment docs.

@axw axw merged commit e712a2e into elastic:v2 Sep 25, 2018
@axw axw deleted the v2-client-side-load-balancing branch September 25, 2018 07:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants