Update Sampler API #243
Merged
Update Sampler API #243
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sampler now accepts a TraceContext, rather than Transaction. NewRatioSampler returns Sampler, and the concrete type has been unexported. Additionally, the ratio sampler now bases its decision on the span (transaction) ID, rather than computing another random number. This also avoids synchronisation on an RNG mutex.
Codecov Report
@@ Coverage Diff @@
## v2 #243 +/- ##
=========================================
+ Coverage 80.5% 80.53% +0.03%
=========================================
Files 91 91
Lines 5376 5375 -1
=========================================
+ Hits 4328 4329 +1
+ Misses 838 837 -1
+ Partials 210 209 -1
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sampler now accepts a TraceContext, rather than
Transaction. NewRatioSampler returns Sampler,
and the concrete type has been unexported.
Additionally, the ratio sampler now bases its
decision on the span (transaction) ID, rather
than computing another random number. This
also avoids synchronisation on an RNG mutex.