module/apmredigo: introduce redigo instrumentation #248
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We introduce module/apmredigo, which provides top-level function for calling redis.Conn.Do with a context, a la ctxhttp.Do. apmredigo also provides a function (Wrap) for wrapping a redis.Conn, diverting Do calls to the aforementioned Do-with-context function. A Conn can be associated with a context using the Conn.WithContext method. Send and Receive are not instrumented. For now, spans should be created for the higher-level operations in which they are used (pub/sub, transactions, etc.)
Codecov Report
@@ Coverage Diff @@
## v2 #248 +/- ##
==========================================
+ Coverage 80.67% 80.71% +0.03%
==========================================
Files 91 92 +1
Lines 5382 5413 +31
==========================================
+ Hits 4342 4369 +27
- Misses 831 836 +5
+ Partials 209 208 -1
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We introduce module/apmredigo, which provides
top-level function for calling redis.Conn.Do
with a context, a la ctxhttp.Do. apmredigo also
provides a function (ContextConn) for binding a
redis.Conn to a given context, diverting Do calls
to the aforementioned Do-with-context function.
Send and Receive are not instrumented. For now,
spans should be created for the higher-level
operations in which they are used (pub/sub,
transactions, etc.)
Closes #35