Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

module/apmrestful: add tracing filter #270

Merged
merged 1 commit into from
Oct 19, 2018
Merged

module/apmrestful: add tracing filter #270

merged 1 commit into from
Oct 19, 2018

Conversation

axw
Copy link
Member

@axw axw commented Oct 19, 2018

Add a Filter for tracing go-restful requests.
Installing the filter into a container,
webservice, or route, will cause the requests
within that scope to be traced, and panics
recovered and reported.

Closes #227

Add a Filter for tracing go-restful requests.
Installing the filter into a container,
webservice, or route, will cause the requests
within that scope to be traced, and panics
recovered and reported.
@codecov-io
Copy link

Codecov Report

Merging #270 into master will increase coverage by 0.13%.
The diff coverage is 92.3%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #270      +/-   ##
==========================================
+ Coverage   81.05%   81.18%   +0.13%     
==========================================
  Files          96       98       +2     
  Lines        5557     5622      +65     
==========================================
+ Hits         4504     4564      +60     
- Misses        834      837       +3     
- Partials      219      221       +2
Impacted Files Coverage Δ
module/apmrestful/route.go 100% <100%> (ø)
module/apmrestful/filter.go 87.8% <87.8%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e7450c7...4457965. Read the comment docs.

@axw axw merged commit 3a39362 into elastic:master Oct 19, 2018
@axw axw deleted the gorestful branch October 19, 2018 10:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants