module/...: fix panic handling in web instrumentations #273
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Introduce a basic HTTP test suite for each of the web framework instrumentation modules to run, to test functionality that is expected to be common across each of them. For now there are just a few tests for some edge cases: - handler does not explicitly write a response - handler panics before writing a response - handler panics after writing a response
axw
force-pushed
the
apmhttp-panic-response
branch
from
dc52bdf
to
c1161e0
Compare
Codecov Report
@@ Coverage Diff @@
## master #273 +/- ##
==========================================
+ Coverage 81.18% 81.46% +0.28%
==========================================
Files 98 99 +1
Lines 5622 5692 +70
==========================================
+ Hits 4564 4637 +73
+ Misses 837 833 -4
- Partials 221 222 +1
Continue to review full report at Codecov.
|
Update all of the web framework instrumentation modules to run the new apmtest.HTTPTestSuite, and fix bugs that fell out. Expose apmhttp.setContext as SetContext, using it in apmrestful to set context. This allows us to set the framework for errors originating from go-restful handlers.
axw
force-pushed
the
apmhttp-panic-response
branch
from
c1161e0
to
cbfe017
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduce a basic HTTP test suite for each of
the web framework instrumentation modules to
run, to test functionality that is expected
to be common across each of them.
For now there are just a few tests for some
edge cases:
This uncovered a handful of bugs in the various
web instrumentation modules which have now
been fixed.
We exposed apmhttp.setContext as SetContext,
using it in apmrestful to set context. This allows us
to set the framework for errors originating from
go-restful handlers.
Fixes #272