Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate to go.elastic.co/fastjson #275

Merged
merged 1 commit into from
Oct 26, 2018
Merged

Conversation

axw
Copy link
Member

@axw axw commented Oct 25, 2018

  • Remove internal/fastjson
  • Use go.elastic.co/fastjson
  • Update go.mod

Closes #228

- Remove internal/fastjson
- Use go.elastic.co/fastjson
- Update go.mod
@codecov-io
Copy link

Codecov Report

Merging #275 into master will decrease coverage by 0.83%.
The diff coverage is 47.25%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #275      +/-   ##
==========================================
- Coverage    81.5%   80.66%   -0.84%     
==========================================
  Files          99       97       -2     
  Lines        5692     5644      -48     
==========================================
- Hits         4639     4553      -86     
+ Misses        832      827       -5     
- Partials      221      264      +43
Impacted Files Coverage Δ
modelwriter.go 93.97% <ø> (ø) ⬆️
tracer.go 84.23% <ø> (ø) ⬆️
model/marshal_fastjson.go 74.46% <40.25%> (-10.57%) ⬇️
model/marshal.go 79.2% <85.71%> (+0.14%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9481792...d81fdae. Read the comment docs.

@axw axw merged commit 26f8fce into elastic:master Oct 26, 2018
@axw axw deleted the extract-fastjson branch October 26, 2018 01:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants