Record all HTTP request/response headers #280
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
axw
force-pushed
the
record-all-headers
branch
from
369b113
to
85a905b
Compare
Record all HTTP request/response headers, with the exception of "Cookie", which we explode and store separately. All headers pass through the field sanitiser. If a header is included multiple times, we store the values as an array of strings. Otherwise, we store just a single string value.
axw
force-pushed
the
record-all-headers
branch
from
85a905b
to
5dabc6a
Compare
Codecov Report
@@ Coverage Diff @@
## master #280 +/- ##
==========================================
- Coverage 80.56% 80.45% -0.11%
==========================================
Files 97 97
Lines 5644 5665 +21
==========================================
+ Hits 4547 4558 +11
- Misses 830 844 +14
+ Partials 267 263 -4
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Record all HTTP request/response headers, with the
exception of "Cookie", which we explode and store
separately.
All headers pass through the field sanitiser. If a
header is included multiple times, we store the
values as an array of strings. Otherwise, we store
just a single string value.
The default value for
ELASTIC_APM_SANITIZE_FIELD_NAMEShas been updated to include "authorization" and "set-cookie".
Closes #277