Reuse tags memory #286
Merged
Reuse tags memory #286
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update model.Context.TAgs and model.SpanContext.Tags to use the model.StringMap type, which is a slice of key/value pairs. Storing tags is now just an append, with no de-duplication (the server will de-duplicate when unmarshalling). When resetting transaction and span objects, we'll now reuse these tags slices.
Codecov Report
@@ Coverage Diff @@
## master #286 +/- ##
==========================================
+ Coverage 80.47% 80.56% +0.09%
==========================================
Files 97 96 -1
Lines 5613 5589 -24
==========================================
- Hits 4517 4503 -14
+ Misses 837 828 -9
+ Partials 259 258 -1
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update model.Context.Tags and model.SpanContext.Tags
to use the model.StringMap type, which is a slice of
key/value pairs. Storing tags is now just an append,
with no de-duplication (the server will de-duplicate
when unmarshalling). When resetting transaction and
span objects, we'll now reuse these tags slices.
Closes #283