module/apmhttp: end client span on body closure #289
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
axw
force-pushed
the
apmhttp-client-closebody-endspan
branch
from
54df514
to
6d388f7
Compare
Codecov Report
@@ Coverage Diff @@
## master #289 +/- ##
==========================================
+ Coverage 80.72% 80.75% +0.03%
==========================================
Files 96 96
Lines 5592 5612 +20
==========================================
+ Hits 4514 4532 +18
- Misses 824 825 +1
- Partials 254 255 +1
Continue to review full report at Codecov.
|
axw
force-pushed
the
apmhttp-client-closebody-endspan
branch
from
6d388f7
to
81e161a
Compare
Don't end HTTP client spans as soon as the response headers have been received, but rather when the response body has been closed or EOF received.
axw
force-pushed
the
apmhttp-client-closebody-endspan
branch
from
81e161a
to
6d37ee2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Don't end HTTP client spans as soon as the response
headers have been received, but rather when the
response body has been closed or EOF received.
Closes #287